Opened 9 years ago

Closed 7 years ago

Last modified 43 years ago

#170 closed Bugs (Fixed)

Indenting a selection with [Tab] breaks Eclipse.

Reported by: jytou Owned by: nobody
Priority: 5 Milestone:
Component: PHP Editor Version: None
Keywords: Cc:

Description

I find indenting several lines at once with the tab key
a very usefull functionality (when you forgot an if or
when you want to format your nice html code which has
been broken by an HTML editor). Unfortunately, this
breaks Eclipse when trying it in the PHP editor.
After this, highlighting doesn't work anymore, and when
I quit Eclipse, I'm told that something went wrong.
A quick look at the .log file gives me this:

!ENTRY org.eclipse.osgi oct. 06, 2004 13:57:34.687
!MESSAGE Application error
!STACK 1
java.lang.IllegalArgumentException: Argument cannot be null
	at org.eclipse.swt.SWT.error(SWT.java:2677)
	at org.eclipse.swt.SWT.error(SWT.java:2616)
	at org.eclipse.swt.SWT.error(SWT.java:2587)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:381)
	at
org.eclipse.swt.widgets.Control.removeKeyListener(Control.java:1597)
	at
org.eclipse.jface.text.TextViewer.removeViewPortUpdate(TextViewer.java:2493)
	at
org.eclipse.jface.text.TextViewer.handleDispose(TextViewer.java:1469)
	at
org.eclipse.jface.text.source.SourceViewer.handleDispose(SourceViewer.java:556)
	at
org.eclipse.jface.text.source.projection.ProjectionViewer.handleDispose(ProjectionViewer.java:1263)
	at
net.sourceforge.phpeclipse.phpeditor.JavaSourceViewer.handleDispose(JavaSourceViewer.java:384)
	at
net.sourceforge.phpeclipse.phpeditor.PHPUnitEditor$AdaptedSourceViewer.handleDispose(PHPUnitEditor.java:448)
	at
org.eclipse.jface.text.TextViewer$1.widgetDisposed(TextViewer.java:1373)
	at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:100)
	at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82)


I would really like this one to get corrected because I
get tricked each time I do this and have to restart
eclipse.

Working on Windows XP with Eclipse 3.0 and even
switched to 3.0.1 to verify that it still doesn't work.

Thanks anyway for the great job!

Change History (6)

comment:1 Changed 9 years ago by nobody

Logged In: NO 

which phpeclipse version do you use.
I'd thought, that this behaviour should be solved in the
version from 20040925?
If not please post the stack traces before the one you
submitted.

comment:2 Changed 9 years ago by jytou

Logged In: YES 
user_id=189626

You're right, it's fixed in the latest release. Sorry for
the disturbance. :-D
Thanx!

comment:3 Changed 9 years ago by jytou

Logged In: YES 
user_id=189626

Well sorry to come back again... but I've just managed to
reproduce this code on a page of mine. So I've deleted the
maximum of the code I could to make it a bit more simple for
you and here it is. You'll find in attachments two
screenshots: before and after indenting, and a third
attachment with the file itself.
It seems to be fixed for most cases though.

comment:4 Changed 9 years ago by jytou

Logged In: YES 
user_id=189626

Of course this is on the 20040925 version this time... ;-)

comment:5 Changed 8 years ago by nobody

Logged In: NO 

I'm still seeing this behavior with Eclipse 3.0.2 and 
PHPEclipse 1.1.3. It only seems to happen when indenting 
large blocks of text (e.g. over 30 lines). Smaller blocks don't 
cause any problems.

comment:6 Changed 7 years ago by bananeweizen

  • Status changed from assigned to closed
Logged In: YES 
user_id=440739

Works fine in current CVS version. Closing as fixed.
Note: See TracTickets for help on using tickets.