Ticket #616 (closed Bugs: fixed)

Opened 2 years ago

Last modified 6 months ago

PHP Editor does not follow links to functions with comments

Reported by: benoit_heinrich Owned by: incastrix
Priority: 5 Milestone: 1.2.2
Component: PHP Editor Version: 1.2.x
Keywords: comments, functions Cc:

Description (last modified by ed_mann) (diff)

Hi,

If you have a PHP file that look like this:

function /*integer*/ getCount()
{
}

then if you reference the getCount() function somewhere in your code, then the PHP editor does not locate the function in the repository (using F3 or the Ctrl-click).


This is probably due to the comment in between the function keyword and the function name.

Probably just a problem in a regexp.


/Benoit

Attachments

616_firtst_patch.diff Download (7.5 KB) - added by incastrix 8 months ago.
fix 616 bug, still something not implemented.
class.php Download (1.1 KB) - added by incastrix 8 months ago.
Test file for fist patch

Change History

Changed 2 years ago by benoit_heinrich

Logged In: YES 
user_id=1888704
Originator: YES

By the way, the problem is also there in the 1.1.8 and could be nice to have a fix there until there is a stable release of the 1.2 ;)

/Benoit

Changed 2 years ago by ed_mann

  • description modified (diff)
  • billable set to 0
  • version changed from 1.2.x to 1.2.0-nightly
  • milestone set to 1.3.x
  • keywords comments, functions added
  • os_platform set to Linux

Changed 13 months ago by incastrix

  • os_platform changed from Linux to Any
  • version changed from 1.2.0-nightly to 1.2.x

Changed 12 months ago by incastrix

  • owner changed from nobody to incastrix
  • status changed from assigned to new
  • milestone changed from 1.3.0 to 1.2.2

Changed 8 months ago by incastrix

fix 616 bug, still something not implemented.

Changed 8 months ago by incastrix

Test file for fist patch

Changed 6 months ago by incastrix

  • status changed from new to closed
  • resolution changed from None to fixed
Note: See TracTickets for help on using tickets.