Opened 6 years ago

Closed 3 years ago

Last modified 18 months ago

#705 closed Feature Requests (fixed)

Undo history size

Reported by: Tilman Owned by: incastrix
Priority: 1 Milestone: 1.3.0
Component: Editor Version: 1.2.x
Keywords: undo history size setting Cc:

Description

Currently the PHPEclipse editor undo history size seems to be 25 and cannot be changed anywhere. Ideally the size should be the value that can be set at
General - Editors - Text Editors - Undo history size
or if for technical reasons this is not possible, at least have its own setting in the PHPEclipse settings. (Although it might be misleading for people to have the same setting at 2 places.)
OR if it stays hard coded at least increase the size from 25 to something like 100. 25 is just not enough. :)

Change History (6)

comment:1 Changed 6 years ago by swayhead

absolutely agree!

comment:2 Changed 6 years ago by swayhead

it seems to me like a bug more than a change request

comment:3 Changed 6 years ago by incastrix

  • os_platform changed from Windows to Any
  • Owner set to incastrix
  • Status changed from new to assigned
  • Version changed from 1.2.0-nightly to 1.2.x

comment:4 Changed 3 years ago by robekras

I fixed this by adding a new method to src->net->sourceforge->phpeclise->phpeditor->PHPUnitEditor.java:

        /*
         * Get the global 'Undo history size' setting
         *
         */
        protected int getUndoHistorySize () {
            IPreferenceStore store= getPreferenceStore ();

            return store != null ? store.getInt("undoHistorySize") : 1000;
        }

And add the following line to the end of method 'public void configure(SourceViewerConfiguration? configuration)' (within PHPUnitEditor.java):

        fUndoManager.setMaximalUndoLevel (this.getUndoHistorySize ());  // Set every editor to the global 'Undo history size'

Now the setting from Preferences->General->Editors->Text Editors->'Undo history size' will be taken.

comment:5 Changed 3 years ago by robekras

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 18 months ago by rubo77

Until the fix is added to the stable release, you have to install PHPEclipse nightly build to get this bugfix:

under Window->Preferences->Install/Update->Available Software Sites

select:

http://phpeclipse.sourceforge.net/update/indigo/nightly/

(be sure, that the checkbox 'Group items by category' is not checked!)

in case you've prior installed the stable release of PHPEclipse uninstall those three Entries first (PHPEclipse, Xdebug and DBG) under 'What is already installed' in the bottom right corner of that screen

Note: See TracTickets for help on using tickets.