Opened 4 years ago
Last modified 3 years ago
#761 reopened Bugs
Highligh not working on functions like echo, print, include, require
| Reported by: | gaj.capuder | Owned by: | ed_mann |
|---|---|---|---|
| Priority: | 1 | Milestone: | 1.2.2 |
| Component: | PHP Editor | Version: | 1.2.1 |
| Keywords: | syntax highlight | Cc: |
Description
Some most common function names are not included in syntax highligh (under keywords):
-echo
-include / include_once
-print
-require / require_once
-die
-exit
Other functions seem to work ok (string, array, print_r, var_dump, etc).
I checked the syntax.xml in the .metadata folder and it actualy doesnt include the functions which i mentioned.
P.S. I installed phpeclipse today from the update site.
Attachments (1)
Change History (14)
Changed 4 years ago by gaj.capuder
comment:1 Changed 4 years ago by ed_mann
comment:2 Changed 4 years ago by ed_mann
gaj.capuder,
I have made some changes to our syntax.xml build script. Please try the nightly (i ran a manual build), to see if the issue is fixed.
Thanks.
comment:3 Changed 4 years ago by ed_mann
- Owner set to ed_mann
comment:4 Changed 4 years ago by ed_mann
- Milestone changed from 1.2.1 to 1.2.2
- os_platform changed from Windows to Any
gaj.capuder,
Can you post a ScreenShot?(SS) of what is expected and what you are getting? There were some questions as to what "highligh" really means.
Thanks.
comment:5 Changed 4 years ago by ed_mann
We have done more work on this and have found that if you start a new workspace with the latest nightly build as of this writing, things will work fine. However if you have a workspace you need to remove the following file.
workspace/.metadata/.plugins/net.sourceforge.phpeclipse/syntax.xml
Restart Eclipse and the new file will be loaded in.
Please try the above and let me know if it fixes your issue.
Thanks.
comment:6 Changed 4 years ago by gaj.capuder
ed_mann,
with highlight i ment the synthax coloring in editor. If i set specific color/boldness for build in function names some of them were not colored.
I actualy managed to fix this problem in a way that i first put phpeclipse 1.1.8 in eclipse and then afterwards i installed latest from the update site so i do not have this problem aynmore.
The problem appeared only if i installed latest phpeclipse in new eclipse workspace.
Thanx.
comment:7 follow-ups: ↓ 10 ↓ 13 Changed 4 years ago by incastrix
PHPEclipse dev team decide to use only plugin syntax.xml and then implement a way to add custom syntaxes.
comment:8 follow-up: ↓ 11 Changed 4 years ago by incastrix
- Resolution set to fixed
- Status changed from new to closed
comment:9 in reply to: ↑ description Changed 4 years ago by hurart
I think the situation is worse now...
PHPEclipse 1.2.2 doesn't support syntax.xml now...
And those lost php-internal-keywords are still forgotten...
comment:10 in reply to: ↑ 7 Changed 4 years ago by hurart
Replying to incastrix:
PHPEclipse dev team decide to use only plugin syntax.xml and then implement a way to add custom syntaxes.
It is not a PhpEclipse?'s programming issue...
The problem is just that the official syntax.xml of PhpEclipse? loses some php-keywords inside...
comment:11 in reply to: ↑ 8 Changed 4 years ago by hurart
Replying to incastrix:
Could you reopen this ticket?
My English is not good... I hope you can understand what I am writing...
However it is just a little issue...
What you have to is just put the php-keywords into the official syntax.xml.
Don't think too much...
I appreciate your good jobs very much, I like PhpEclipse? indeed.
comment:12 Changed 4 years ago by ed_mann
- Resolution fixed deleted
- Status changed from closed to reopened
I have re-opened this issue. i have noticed things missing as well. I will need to check the code that builds the syntax.xml file. Also need to make sure i don't have an old cache copy that is causing the issue. I will post my update when i find out anything.
comment:13 in reply to: ↑ 7 Changed 4 years ago by hurart
Replying to incastrix:
The new release in 2009-10-09 looks much better, thank you very much.
Because there are still some php functions not included in syntax.xml, such as is_int(), is_integer(), I added them into my syntax.xml into the plugin jar by unzip / zip it.
I know that PHPEclipse dev team decide to use only plugin syntax.xml and then implement a way to add custom syntaxes, and it is a very good idea, and I am waiting for this new feature;
but for the PHP reserved keywords and built-in functions, maybe you can open syntax.xml to public for maintiaing, then put it on this site for downloading.
Any way, appreciate again.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/eclipsebutton_med.png)
(In [1641]) Updating syntax.xml to attempt fix issues reported in ticket #761
addresses #761